Fix Elasticsearch query runner error: 'str' object has no attribute 'pop' error when parsing query #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6941 +/- ##
==========================================
+ Coverage 63.76% 63.80% +0.03%
==========================================
Files 161 161
Lines 13085 13087 +2
Branches 1812 1812
==========================================
+ Hits 8344 8350 +6
+ Misses 4438 4434 -4
Partials 303 303
|
jcowley
force-pushed
the
fix-elasticsearch
branch
3 times, most recently
from
23ac140 to
667699c
Compare
|
Hmmm, wonder if this was caused by the pseudojson change back in Jan? ec1c4d0 That being said, this bug definitely needs fixing. 😄 @AndrewChubatiuk Are you ok to review this? |
|
Thanks @AndrewChubatiuk. 😄 |
justinclift
approved these changes
May 2, 2024
There was a problem hiding this comment.
Looks straight forward enough, and @AndrewChubatiuk didn't spot anything wrong. 😄
|
@jcowley Thanks for spotting this, and fixing it. 😄 |
|
No problem. Thanks for getting it merged in. |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Fix Elasticsearch query runner (refactored version not yet released)
How is this tested?
I needed redash to work with elasticsearch 7.10, but the current v10.1.0 release does not support it. There was a major refactor of the elasticsearch query runner in #5794, but that code has not yet been released. So, I got the latest from master and tried it out.
I'm not sure how this code was tested originally, but it doesn't work because of a very minor bug. When building the elasticsearch query, it's trying to call
pop()on thequeryparameter which is of typestr, and there is nopop()method onstr. Any attempt to run an elasticsearch query results in the error:'str' object has no attribute 'pop' error when parsing queryIt needs to be converted to a dictionary, which is a one line change. Then it works fine.
Not sure how this wasn't caught earlier. Maybe no one has tried it out yet? I do appreciate all the hard work that @NicolasLM, @susodapop, and @wwl717195673 put into the refactor. It's been working well for us after this fix.
Related Tickets & Documents
#5794