Revert "Switch from numeral to numbro (#6344)"

[eradman]

This reverts commit f8934b8.

What type of PR is this?

• Bug fix

Description

Using a format string of 0 does not round to the nearest integer in Numbro

Related Tickets & Documents

numbro/issues/745

[codecov]

Codecov Report

Merging #6595 (d9c5478) into master (9df6f80) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6595   +/-   ##
=======================================
  Coverage   62.39%   62.39%           
=======================================
  Files         161      161           
  Lines       13179    13179           
  Branches     1796     1796           
=======================================
  Hits         8223     8223           
  Misses       4672     4672           
  Partials      284      284           

[justinclift]

Well damn. Oh well, if you reckon this is the best approach for now, then I'm ok with it. 😄

[masayuki038]

Oh my god... But you realized it now. Nice catch !

[justinclift]

Looking at the issue @eradman filed on the numbro repo, they might be able to suggest a workaround or fix the problem themselves.

So, we're probably best to leave this for a few days and see how that issue goes. If nothing substantial turns up by then, we can merge this to revert back to numeral.

[eradman]

Agreed; we should wait and see if there is a workaround we can use.

[masayuki038]

Hi @guidopetri @eradman Thanks for fixing this.
This PR was merged. So, I checked the behavior. However, it looks like it didn't change.

I checked the source code in redash/redash:preview. However, I didn't find any issues...

[masayuki@localhost redash]$ docker images | grep preview
redash/redash                 preview         e60210000a6f   2 days ago          1.81GB
[masayuki@localhost redash]$ docker ps | grep redash-server-1
f28d906942b2   redash/redash:preview                      "/app/bin/docker-ent…"   About an hour ago   Up About an hour             0.0.0.0:5678->5678/tcp, :::5678->5678/tcp, 0.0.0.0:5001->5000/tcp, :::5001->5000/tcp   redash-server-1
[masayuki@localhost redash]$ docker exec redash-server-1 cat ./viz-lib/src/lib/value-format.tsx | grep numeral.options.scalePercentBy100
numeral.options.scalePercentBy100 = false;

Am I doing something wrong?

[eradman]

A build from top of tree (392b930) shows that the previous behavior was restored

Perhaps there is a delay in updating the docker image?

[masayuki038]

@eradman Thanks for your confirmation!
It may be something wrong in my env. I will check it again. thank you.

[masayuki038]

Indeed, the image created with make compose_build gave the expected value...
I will check redash/redash:preview later.

[guidopetri]

@masayuki038 it might be a caching issue, where docker didn't pull the latest image.

[masayuki038]

@guidopetri Thanks for your comment.
I ran docker rmi redash/redash:preview... I'll try it on another machine. thank you.

[masayuki038]

Today, I tried redash/redash:preview again and it is fine. It seemed to be a cache issue. thank you.