-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODBC Based Databricks Connector #4814
Conversation
1. Parse types. 2. Send additional connection options. 3. Correctly parse errors.
{selectedType.type === "databricks" && ( | ||
<small> | ||
By using the Databricks Data Source you agree to the Databricks JDBC/ODBC{" "} | ||
<a href="https://databricks.com/spark/odbc-driver-download" target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see it. Maybe some adblocker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange. It's not an adblocker. Just not compatible in Firefox. Loads fine in Chrome and Safari.
def _get_connection(self): | ||
host = self.configuration["host"] | ||
def _get_cursor(self): | ||
connection_string = _build_odbc_connection_string( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth documenting where this came from in the DB Documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not from there :) It's from the tableau connector implementation.
Hey there- I'm a bot, here to let you know that some code in this PR might not Please see that Pull Request's description for more details. |
What type of PR is this?
Description
Updated the Databricks connector to use their ODBC driver instead of the PyHive connector.