Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODBC Based Databricks Connector #4814

Merged
merged 13 commits into from
Apr 24, 2020
Merged

ODBC Based Databricks Connector #4814

merged 13 commits into from
Apr 24, 2020

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Apr 19, 2020

What type of PR is this?

  • Refactor

Description

Updated the Databricks connector to use their ODBC driver instead of the PyHive connector.

{selectedType.type === "databricks" && (
<small>
By using the Databricks Data Source you agree to the Databricks JDBC/ODBC{" "}
<a href="https://databricks.com/spark/odbc-driver-download" target="_blank" rel="noopener noreferrer">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the terms and conditions on this page.

driver-download-page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see it. Maybe some adblocker?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. It's not an adblocker. Just not compatible in Firefox. Loads fine in Chrome and Safari.

def _get_connection(self):
host = self.configuration["host"]
def _get_cursor(self):
connection_string = _build_odbc_connection_string(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth documenting where this came from in the DB Documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not from there :) It's from the tableau connector implementation.

@restyled-io
Copy link
Contributor

restyled-io bot commented Apr 23, 2020

Hey there-

I'm a bot, here to let you know that some code in this PR might not
match the team's automated styling. I ran the team's auto-reformatting tools on
the files changed in this PR and found some differences. Those differences can
be seen in #4826.

Please see that Pull Request's description for more details.

@arikfr arikfr merged commit ea8a075 into master Apr 24, 2020
@guidopetri guidopetri deleted the db-odbc branch July 22, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants