Update EditInPlace to use Antd components #4493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This updates EditInPlace to use Antd components instead of rd-form.
I considered using Antd's Typography, but it's not 100% the same thing and Typography doesn't seem to support multi-line with Shift+enter or Textarea as editor.
Anyway, most of the existing EditInPlace's didn't change, aside from the titles that now have a smaller font-size when being edited:
Before

After

Also took the opportunity to allow
className
in the component.