Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Sheets: friendlier error message in case of an API error and more reliable test connection #3883

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Google Sheets: friendlier error message in case of an API error and more reliable test connection #3883

merged 2 commits into from
Jun 12, 2019

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jun 6, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

  1. Changed Test Connection to try and open a spreadsheet to verify that credentials actually work.
  2. Show friendlier message when receiving an API error:
Before After
image image

@weekly-digest weekly-digest bot mentioned this pull request Jun 10, 2019
Closed
@arikfr arikfr merged commit 1630cbb into master Jun 12, 2019
@arikfr arikfr deleted the gs-friendly-error branch June 12, 2019 08:47
@weekly-digest weekly-digest bot mentioned this pull request Jun 17, 2019
Closed
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@arikfr @harveyrendell
Google Sheets: friendlier error message in case of an API error and m…
85cf432 
…ore reliable test connection (getredash#3883)

* Google Sheets: friendlier error message in case of an APIError and more reliable test connection.

* Pleasing the pep8 gods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arikfr