Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup/*.sh scripts inconsistant use of /opt/redash #3727

Closed
DALDEI opened this issue Apr 20, 2019 · 2 comments · Fixed by #3740
Closed

setup/*.sh scripts inconsistant use of /opt/redash #3727

DALDEI opened this issue Apr 20, 2019 · 2 comments · Fixed by #3740

Comments

@DALDEI
Copy link

DALDEI commented Apr 20, 2019

Issue Summary

The docker setup scripts in setup/*.sh make inconsistent use of /opt/redash.
At the beginning of the script there is an env variable set, implying it could be another path (say a path that doesnt require sudo /root ) -- but no.
the path /opt/redash is hard coded in many places.

Docker installs should not require local host hard coded paths in root-only-accessable directories.

@arikfr
Copy link
Member

arikfr commented Apr 28, 2019

I believe that #3740 fixes this. I'm just not sure if this is correct:
https://github.com/getredash/redash/pull/3740/files#diff-857898594f6154f687a8e971526f0749L63

If you have the opportunity to test it out, it will help with expediting merging #3740.

Btw, what path are you planning on using instead of /opt/redash?

Thanks.

@jezdez
Copy link
Member

jezdez commented Apr 29, 2019

I believe that #3740 fixes this. I'm just not sure if this is correct:
getredash/redash/pull/3740/files#diff-857898594f6154f687a8e971526f0749L63

That works as expected, the resulting content is export COMPOSE_FILE=/opt/redash/docker-compose.yml in ~/.profile.

If you have the opportunity to test it out, it will help with expediting merging #3740.

Btw, what path are you planning on using instead of /opt/redash?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants