Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS exception on parsing columns with integer col.name #1960

Closed
rgovindji opened this issue Sep 20, 2017 · 2 comments · Fixed by #2352
Closed

JS exception on parsing columns with integer col.name #1960

rgovindji opened this issue Sep 20, 2017 · 2 comments · Fixed by #2352
Assignees

Comments

@rgovindji
Copy link

Found a bug? Please fill out the sections below... thank you 👍

Issue Summary

In query-result.js line 354 if col.name is returned as a long i.e '404' then exception is thrown.
angular.js:13920 TypeError: n.split is not a function

Steps to Reproduce

  1. Make an elastic search query which returns a list of buckets that have integers as the key names
  2. When the response is returned, you will see the exception

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?

Technical details:

  • Redash Version: v2.0.0
  • Browser/OS: Mac / Chrome
  • How did you install Redash: Docker
@arikfr
Copy link
Member

arikfr commented Dec 12, 2017

At first I thought that we should handle this in the client code, but on second thought I think that the column name should be a string and the fix should be in the query runner.

@rgovindji
Copy link
Author

rgovindji commented Dec 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants