Merge pull request #2308 from getredash/fix_params

Fix: parameters list was resetting when adding a new parameter
getredash · Feb 11, 2018 · 953efc4 · 953efc4
2 parents 29c675b + 5343dd9
commit 953efc4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/client/app/services/query.js b/client/app/services/query.js
@@ -102,6 +102,8 @@ class Parameters {
       parameters = uniq(collectParams(parts));
     } catch (e) {
       logger('Failed parsing parameters: ', e);
+      // Return current parameters so we don't reset the list
+      parameters = pluck(this.query.options.parameters, 'name');
     }
     return parameters;
   }
@@ -123,13 +125,13 @@ class Parameters {
 
     parameterNames.forEach((param) => {
       if (!has(parametersMap, param)) {
-        this.query.options.parameters.push({
+        this.query.options.parameters.push(new Parameter({
           title: param,
           name: param,
           type: 'text',
           value: null,
           global: false,
-        });
+        }));
       }
     });