Skip favorites dropdown loading state on init (#4318)

getredash · Oct 31, 2019 · 74dbb8a · 74dbb8a
1 parent 36638be
commit 74dbb8a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/client/app/components/app-header/components/FavoritesDropdown.jsx b/client/app/components/app-header/components/FavoritesDropdown.jsx
@@ -15,8 +15,8 @@ export default function FavoritesDropdown({ fetch, urlTemplate }) {
   const noItems = isEmpty(items);
   const urlCompiled = useMemo(() => template(urlTemplate), [urlTemplate]);
 
-  const fetchItems = useCallback(() => {
-    setLoading(true);
+  const fetchItems = useCallback((showLoadingState = true) => {
+    setLoading(showLoadingState);
     fetch().$promise
       .then(({ results }) => {
         setItems(results);
@@ -27,7 +27,7 @@ export default function FavoritesDropdown({ fetch, urlTemplate }) {
   }, [fetch]);
 
   // fetch items on init
-  useEffect(fetchItems, []);
+  useEffect(() => fetchItems(false), []);
 
   // fetch items on click
   const onVisibleChange = visible => visible && fetchItems();