Typo and grammar fixes #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammichaelwood
suggested changes
Aug 20, 2018
shared-src/docs-tech-guide.rst
Outdated
| @@ -463,11 +463,11 @@ Clone to local | |||
|
|
|||
| From your own fork of the repo on GitHub, | |||
| select the :guilabel:`Clone or download` button. | |||
| Copy the URI from the text box that opens up. | |||
| Copy the URL from the text box that opens. | |||
There was a problem hiding this comment.
For those following along, if the web address has a protocol in front of it, it's a URL. If it doesn't, it's a URI. In the case of this dialog, if you use clone with HTTPS, then it's a URL because the string GitHub shows starts with https://. If you clone with SSH, then it's a URI because there is no ssh://.
So @adammichaelwood is correct, but unnecessarily pedantic.
|
Welcome to ODK and thanks so much for sending this PR in, @lesley-morgan. These changes look great and I hope @adammichaelwood merges them soon. Looking forward to your next PR! |
adammichaelwood
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #96
What is included in this PR?
Typos and grammar.