Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Allow replace/remove of mocked responses #8499

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

bblommers
Copy link
Collaborator

Fixes #8449

@bblommers bblommers added this to the 5.0.27 milestone Jan 18, 2025
@bblommers bblommers force-pushed the core-replace-remove-mock branch from 1788b96 to 514c8e1 Compare January 19, 2025 19:28
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (4c1321a) to head (514c8e1).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
moto/core/responses_custom_registry.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8499      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files        1224     1224              
  Lines      105925   105940      +15     
==========================================
+ Hits        98123    98136      +13     
- Misses       7802     7804       +2     
Flag Coverage Δ
servertests 27.74% <13.33%> (-0.01%) ⬇️
unittests 92.60% <73.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers marked this pull request as ready for review January 19, 2025 20:19
@bblommers bblommers merged commit 209e4e1 into getmoto:master Jan 19, 2025
52 of 53 checks passed
@bblommers bblommers deleted the core-replace-remove-mock branch January 19, 2025 20:19
Copy link

@ralphie0112358 ralphie0112358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

responses_mock.remove() causes infinite loop
2 participants