Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOT - Improve Job and JobTemplate #8322

Merged

Conversation

jsuchenia
Copy link
Contributor

Hello

In this PR I'd like to enhance IoT Job object and JobTemplate

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 99.05660% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (c8d0e1c) to head (a9da6e4).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
moto/iot/models.py 98.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8322   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files        1159     1159           
  Lines      100942   101037   +95     
=======================================
+ Hits        95462    95558   +96     
+ Misses       5480     5479    -1     
Flag Coverage Δ
servertests 28.90% <35.84%> (+<0.01%) ⬆️
unittests 94.54% <99.05%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsuchenia jsuchenia force-pushed the feat/improve-iot-job-and-jobtemplate branch 3 times, most recently from c35e430 to e323930 Compare November 16, 2024 18:37
@jsuchenia jsuchenia force-pushed the feat/improve-iot-job-and-jobtemplate branch from e323930 to a9da6e4 Compare November 17, 2024 11:09
@jsuchenia jsuchenia requested a review from bblommers November 17, 2024 11:10
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you so much @jsuchenia!

@bblommers bblommers added this to the 5.0.21 milestone Nov 17, 2024
@bblommers bblommers merged commit 01829b2 into getmoto:master Nov 17, 2024
53 checks passed
@bblommers bblommers changed the title Improve IoT Job and JobTemplate IOT - Improve Job and JobTemplate Nov 17, 2024
@jsuchenia jsuchenia deleted the feat/improve-iot-job-and-jobtemplate branch November 17, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants