Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove *_count fields #290

Merged
merged 1 commit into from
Dec 10, 2024
Merged

misc: Remove *_count fields #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lago_python_client/models/billable_metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ class BillableMetricResponse(BaseResponseModel):
field_name: Optional[str]
created_at: str
filters: BillableMetricFilters
active_subscriptions_count: int
draft_invoices_count: int
plans_count: int


class BillableMetricEvaluateExpressionEvent(BaseModel):
Expand Down
2 changes: 0 additions & 2 deletions lago_python_client/models/plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ class PlanResponse(BaseResponseModel):
charges: Optional[ChargesResponse]
minimum_commitment: Optional[MinimumCommitmentResponse]
usage_thresholds: Optional[UsageThresholdsResponse]
active_subscriptions_count: Optional[int]
draft_invoices_count: Optional[int]
taxes: Optional[TaxesResponse]


Expand Down
4 changes: 0 additions & 4 deletions lago_python_client/models/tax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ class TaxResponse(BaseResponseModel):
code: str
rate: float
description: Optional[str]
add_ons_count: Optional[int]
customers_count: Optional[int]
plans_count: Optional[int]
charges_count: Optional[int]
applied_to_organization: bool
created_at: str

Expand Down
5 changes: 1 addition & 4 deletions tests/fixtures/billable_metric.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
"key": "country",
"values": ["france", "italy", "spain"]
}
],
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"plans_count": 0
]
}
}
10 changes: 2 additions & 8 deletions tests/fixtures/billable_metric_index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@
"expression": "1 + 2",
"field_name": "amount_sum",
"created_at": "2022-04-29T08:59:51Z",
"filters": [],
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"plans_count": 0
"filters": []
},
{
"lago_id": "b7ab2926-1de8-4428-9bcd-779314a11111",
Expand All @@ -31,10 +28,7 @@
"expression": "1 + 2",
"field_name": "amount_sum",
"created_at": "2022-04-30T08:59:51Z",
"filters": [],
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"plans_count": 0
"filters": []
}
],
"meta": {
Expand Down
10 changes: 0 additions & 10 deletions tests/fixtures/plan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
"trial_period": 3.0,
"pay_in_advance": true,
"bill_charges_monthly": null,
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"charges": [
{
"lago_id": "51c1e851-5be6-4343-a0ee-39a81d8b4ee1",
Expand Down Expand Up @@ -49,10 +47,6 @@
"code": "tax_code",
"rate": 15.0,
"description": "tax_desc",
"add_ons_count": 0,
"customers_count": 0,
"plans_count": 0,
"charges_count": 0,
"applied_to_organization": false,
"created_at": "2022-04-29T08:59:51Z"
}
Expand Down Expand Up @@ -80,10 +74,6 @@
"code": "tax_code",
"rate": 15.0,
"description": "tax_desc",
"add_ons_count": 0,
"customers_count": 0,
"plans_count": 0,
"charges_count": 0,
"applied_to_organization": false,
"created_at": "2022-04-29T08:59:51Z"
}
Expand Down
12 changes: 1 addition & 11 deletions tests/fixtures/plan_index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
"trial_period": 3.0,
"pay_in_advance": true,
"bill_charges_monthly": null,
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"charges": [
{
"lago_id": "51c1e851-5be6-4343-a0ee-39a81d8b4ee1",
Expand All @@ -32,11 +30,7 @@
"amount": "0.22"
},
"values": {
"country": [
"france",
"italy",
"spain"
]
"country": ["france", "italy", "spain"]
},
"invoice_display_name": "Europe"
}
Expand All @@ -62,8 +56,6 @@
"trial_period": 2.0,
"pay_in_advance": true,
"bill_charges_monthly": null,
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"charges": [
{
"lago_id": "dfdc725d-6341-4d61-831e-4ac9ccd509c0",
Expand Down Expand Up @@ -93,8 +85,6 @@
"trial_period": 0.0,
"pay_in_advance": true,
"bill_charges_monthly": null,
"active_subscriptions_count": 0,
"draft_invoices_count": 0,
"charges": []
}
],
Expand Down
4 changes: 0 additions & 4 deletions tests/fixtures/tax.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
"code": "tax_code",
"rate": 15.0,
"description": "tax_desc",
"add_ons_count": 0,
"customers_count": 0,
"plans_count": 0,
"charges_count": 0,
"applied_to_organization": false,
"created_at": "2022-04-29T08:59:51Z"
}
Expand Down
7 changes: 0 additions & 7 deletions tests/fixtures/tax_index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
"name": "tax_name_1",
"code": "tax_code_1",
"rate": 15.0,
"add_ons_count": 0,
"customers_count": 0,
"plans_count": 0,
"description": "tax_desc_1",
"applied_to_organization": false,
"created_at": "2022-04-29T08:59:51Z"
Expand All @@ -17,10 +14,6 @@
"name": "tax_name_2",
"code": "tax_code_2",
"rate": 20.0,
"add_ons_count": 0,
"customers_count": 0,
"plans_count": 0,
"charges_count": 0,
"description": "tax_desc_2",
"applied_to_organization": false,
"created_at": "2022-04-29T08:59:51Z"
Expand Down