Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current Filters architecture makes it impossible to have 2 sets of filters on the same page, because of how the filters are stored in the URL params.
Description
Added a new prop
filtersNamePrefix
which enables us to have multiple Filters on the same page by prefixing their name:To use this functionality, we need to pass the new prop in two places:
formatFiltersForQuery
functionImplementation
I've tried to keep the existing structure, without changing too many things. Most of the work was done inside
useFilters
, since it assumed a single set of filters in most cases (for example when setting a quick filter, or when resetting filters, it was deleting everything from the search params).Screenshot