misc: start migration of Combobox to Tailwind #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We're migrating our app to use Tailwind. This PR is a kickoff for the Combobox one.
Description
Many things happens here, from simple TW switch to some UI and logic change, to make sure the UI looks homogeneous
Please note:
MultipleComboBoxListalso have a change as I set themaxHeightrule in the MUI theme file.react-windowlib to get last bugfixesComboBoxPopperFactorylose some padding rules as they are now spread more "close" to the elements concerned (ComboboxListandComboBoxVirtualizedList.tsx)Next steps
The Combobox TW migration is not done.
I plan to then handle the more "noisy" part by renaming
ComboBoxItemintoComboBoxItemWrapperand creating a newComboBoxItemcomponent that will return a TW wrapper for the exported constItemincluded inComboBoxItemWrapper.This new component is widely used in the app and all imports will be updated
Some rules may need to be placed in the MUI theme file and once done, the same process will be reproduce for the multiple combobox (with some potential other problems in the road)
Let's be honest, this code is crap and should be fixed differently for the long term. We should probably (i) upgrade our MUI package to v6 to (ii) rely more on their new API and internal tools, rather than making everything custom as today.
That will for sure help us removing bunch of code and components we built.