Skip to content

Commit

Permalink
hotfix: Remove filters from credit notes (#2003)
Browse files Browse the repository at this point in the history
* feat(CreditNotesTable): add showFilters prop

* fix: remove filters from invoice/customer credit notes table
  • Loading branch information
stephenlago99 authored Jan 27, 2025
1 parent b645a07 commit ca63148
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 16 deletions.
36 changes: 20 additions & 16 deletions src/components/creditNote/CreditNotesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ type TCreditNoteTableProps = {
variables: LazyQueryHookOptions['variables'] | undefined
customerTimezone?: TimezoneEnum
tableContainerSize?: ResponsiveStyleValue<TableContainerSize>
showFilters?: boolean
}

const CreditNoteTableItemSkeleton = () => {
Expand All @@ -133,6 +134,7 @@ const CreditNotesTable = ({
customerTimezone,
error,
tableContainerSize,
showFilters = true,
}: TCreditNoteTableProps) => {
const { translate } = useInternationalization()
const navigate = useNavigate()
Expand Down Expand Up @@ -174,22 +176,24 @@ const CreditNotesTable = ({

return (
<>
<div className="box-border flex w-full flex-col gap-3 p-4 shadow-b md:px-12 md:py-3">
<Filters.Provider
availableFilters={[
AvailableFiltersEnum.amount,
AvailableFiltersEnum.creditNoteCreditStatus,
AvailableFiltersEnum.currency,
AvailableFiltersEnum.customerExternalId,
AvailableFiltersEnum.invoiceNumber,
AvailableFiltersEnum.issuingDate,
AvailableFiltersEnum.creditNoteReason,
AvailableFiltersEnum.creditNoteRefundStatus,
]}
>
<Filters.Component />
</Filters.Provider>
</div>
{showFilters && (
<div className="box-border flex w-full flex-col gap-3 p-4 shadow-b md:px-12 md:py-3">
<Filters.Provider
availableFilters={[
AvailableFiltersEnum.amount,
AvailableFiltersEnum.creditNoteCreditStatus,
AvailableFiltersEnum.currency,
AvailableFiltersEnum.customerExternalId,
AvailableFiltersEnum.invoiceNumber,
AvailableFiltersEnum.issuingDate,
AvailableFiltersEnum.creditNoteReason,
AvailableFiltersEnum.creditNoteRefundStatus,
]}
>
<Filters.Component />
</Filters.Provider>
</div>
)}

<ScrollContainer
ref={listContainerElementRef}
Expand Down
1 change: 1 addition & 0 deletions src/components/customers/CustomerCreditNotesList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export const CustomerCreditNotesList = ({
customerTimezone={customerTimezone}
error={error}
variables={variables}
showFilters={false}
/>
)}
</div>
Expand Down
1 change: 1 addition & 0 deletions src/pages/InvoiceCreditNoteList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const InvoiceCreditNoteList = () => {
customerTimezone={data?.invoice?.customer.applicableTimezone || TimezoneEnum.TzUtc}
error={error}
variables={variables}
showFilters={false}
/>
)}
</>
Expand Down

0 comments on commit ca63148

Please sign in to comment.