Revert "feat(invoice): Avoid generating 0 amount charge fees (#3032)" #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 36315a9.
brunomiguelpinto
approved these changes
Jan 16, 2025
annvelents
approved these changes
Jan 16, 2025
lovrocolic
approved these changes
Jan 16, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jan 17, 2025
## Context This PR is related to the rollback of the zero amount removal (See #3059) It appears that some customers are relying on the fees on some invoice webhooks to retrieve the billing period info. ## Description This PR makes sure that the billing period info are always sent in webhooks / exposed in the API when, to ensure that users can rely on it even if no fees have been created
vincent-pochet
added a commit
that referenced
this pull request
Jan 17, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jan 23, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jan 23, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jan 27, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jan 27, 2025
vincent-pochet
added a commit
that referenced
this pull request
Jan 27, 2025
#3059) (#3068) ## Description This PR follow #3020 the goal is to stop generating empty fees (0 units, amount and events without adjustments or true up fees). The reason behind this change is scalability as for now, depending on the plan setups, it appears that 98% of generated fees does not have an amount... **NOTE:** a new feature will improve the edit fees feature since this PR will prevent creation of adjustment fees from the UI if no event have been received for a specific billable metric on a period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 36315a9.