Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] - Input label position #27

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Conversation

maganezf
Copy link
Contributor

Description

fix: input label position (the label position is correct when the input already has a value)
extra – fix: code global styles formatting

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test this using storybook

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

the label position is correct when the input already has a value
@maganezf maganezf added the patch Increment the patch version when merged label Apr 16, 2022
@maganezf maganezf requested a review from wendelfreitas April 16, 2022 18:58
@maganezf maganezf self-assigned this Apr 16, 2022
@maganezf maganezf removed the request for review from wendelfreitas April 16, 2022 18:58
@maganezf maganezf merged commit 6785763 into master Apr 16, 2022
@maganezf maganezf deleted the fix/input-label-position branch April 16, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant