-
Notifications
You must be signed in to change notification settings - Fork 33.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish translation #1378
Spanish translation #1378
Conversation
@getify This is the initial translation for spanish. Should we leave a Spanish branch? |
@getify I made a PR to master to setup the workflow of the translation before moving into bigger chucks of work. I have people interested in this so would be great to clear this details before adding more people too. |
The PR looks good. But I don't want to create the branch and merge chunk by chunk, because that makes the main repo very noisy while translations (especially multiple ones) are being worked on. What worked well on the official Chinese translation was that the entire translation was managed in their own repo. Once they felt they were substantially done (with all 6 books), they made one PR to a new branch (that I created for them) and we added all the translation work. At that point, I promoted Joe to a repo maintainer so he could further manage that translation's branch from that point forward. That strategy minimizes the noise on the repo during the churn of translations, with only the (hopefully much less) noise of maintenance of translations hitting the main repo. I would be willing to add one book at a time to the main repo, if it was really desired to go book-by-book, but for the stated reasons of minimizing the issue-traffic on this repo, I don't want to add chapter-by-chapter. I understand why you're wanting to work out workflow. I get that. I would say the simplest thing is to establish what workflows work best for you, on your own repo. I don't have any opinion on how you want to manage the translation process. That should be up to you! That's why deferring the merging to the main repo branch until "the end" frees you up from concerns about workflow. Once you have a book (or all six books) ready to merge, there's a dramatically simpler workflow involved:
Does that help clarify workflow? |
Absolutely. I understand now the reason why having multiple commits to the man repo can be painfull and noisy, and having my own repo as a staging environment would be the best, that way I can optimze workflow without getting you involved in the needy greedy. I will then:
Without further ado, I will PR per book with all the contributors in the PR (for the moment). |
Spanish Translation Repo:Translation Staging fork |
@EstebanMarin gotcha |
@EstebanMarin do you want to have a talk before starting? |
Hi all. Also I would like to collaborate, actually Im working on my own documentation of Javascript (https://github.com/Zenfeuer/Weird-Javascript) and can help to translate this to spanish :). |
@Zenfeuer Many thanks. I noticed that the link was pointing to an old Repo. I move the translation into an own organization rather than a a personal repo. That way people can get more engaged into the process. https://github.com/You-Dont-Know-JS-ES/Traduccion |
Cool @EstebanMarin ! I'm going to use the new repo then 👍 |
@EstebanMarin I would like to help to translate the books. Can I use the new repo you created? |
hello folks!! where can I see the progress on this issue? is there another repo link I can go and see the current status? thanks! |
Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).