Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation #1378

Closed
wants to merge 1 commit into from
Closed

Spanish translation #1378

wants to merge 1 commit into from

Conversation

EstebanMarin
Copy link

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).

@EstebanMarin
Copy link
Author

@getify This is the initial translation for spanish. Should we leave a Spanish branch?

@EstebanMarin
Copy link
Author

@getify I made a PR to master to setup the workflow of the translation before moving into bigger chucks of work. I have people interested in this so would be great to clear this details before adding more people too.
thanks again!

@getify
Copy link
Owner

getify commented Nov 13, 2018

The PR looks good. But I don't want to create the branch and merge chunk by chunk, because that makes the main repo very noisy while translations (especially multiple ones) are being worked on.

What worked well on the official Chinese translation was that the entire translation was managed in their own repo. Once they felt they were substantially done (with all 6 books), they made one PR to a new branch (that I created for them) and we added all the translation work. At that point, I promoted Joe to a repo maintainer so he could further manage that translation's branch from that point forward.

That strategy minimizes the noise on the repo during the churn of translations, with only the (hopefully much less) noise of maintenance of translations hitting the main repo.

I would be willing to add one book at a time to the main repo, if it was really desired to go book-by-book, but for the stated reasons of minimizing the issue-traffic on this repo, I don't want to add chapter-by-chapter.


I understand why you're wanting to work out workflow. I get that.

I would say the simplest thing is to establish what workflows work best for you, on your own repo. I don't have any opinion on how you want to manage the translation process. That should be up to you!

That's why deferring the merging to the main repo branch until "the end" frees you up from concerns about workflow.

Once you have a book (or all six books) ready to merge, there's a dramatically simpler workflow involved:

  1. File an issue asking for the branch, named for the official language of the translation.

  2. Once that branch is created, file a single rolled-up PR to that branch.

  3. Once I merge that, I will promote you to repo maintainer so that you can manage all further translation work on that branch (including triaging any issues that come into the main repo).

  4. Ideally, at that point, no further work is going on in your original repo. Think of your repo as a staging ground to work out all the translation stuff, and then merging as the "end" of that staging environment.

Does that help clarify workflow?

@EstebanMarin EstebanMarin changed the title Prefase translation Spanish translation Nov 13, 2018
@EstebanMarin
Copy link
Author

EstebanMarin commented Nov 13, 2018

Absolutely. I understand now the reason why having multiple commits to the man repo can be painfull and noisy, and having my own repo as a staging environment would be the best, that way I can optimze workflow without getting you involved in the needy greedy.

I will then:

  1. Rename the PR so anyone interested can find this thread.

  2. Leave the issue 1377, also for the same reasons above.

  3. I will leave in these Thread, PR, and ISSUE, link to the staging repo. That way we do not loose any possible contributors.

Without further ado, I will PR per book with all the contributors in the PR (for the moment).

@EstebanMarin
Copy link
Author

EstebanMarin commented Nov 13, 2018

Spanish Translation Repo:

Translation Staging fork
Note: Though it is a personal repo as discussed with @getify here this is the best approch. Also, all contributors will be mentioned and added in the Per Chapter PR.

@camilomontoyau
Copy link

@EstebanMarin gotcha
@getify thanks for taking the time to answer

@camilomontoyau
Copy link

@EstebanMarin do you want to have a talk before starting?
btw, I'm from Colombia and [email protected] is my e-mail

@EstebanMarin EstebanMarin deleted the pr/TranslationToES branch November 14, 2018 21:10
@EstebanMarin EstebanMarin restored the pr/TranslationToES branch November 14, 2018 21:10
@Zenfeuer
Copy link

Zenfeuer commented Dec 6, 2018

Hi all.

Also I would like to collaborate, actually Im working on my own documentation of Javascript (https://github.com/Zenfeuer/Weird-Javascript) and can help to translate this to spanish :).

@EstebanMarin
Copy link
Author

@Zenfeuer Many thanks. I noticed that the link was pointing to an old Repo. I move the translation into an own organization rather than a a personal repo. That way people can get more engaged into the process. https://github.com/You-Dont-Know-JS-ES/Traduccion
(here)[https://github.com/You-Dont-Know-JS-ES/Traduccion]
I also archived the old one, and updated the readme. Thanks for that and keen to see a lot of PRs from your end!

@Zenfeuer
Copy link

Zenfeuer commented Dec 6, 2018

Cool @EstebanMarin ! I'm going to use the new repo then 👍

@gerardolgvr
Copy link

@EstebanMarin I would like to help to translate the books. Can I use the new repo you created?

@horacioh
Copy link

horacioh commented Aug 4, 2021

hello folks!!

where can I see the progress on this issue? is there another repo link I can go and see the current status?

thanks!

This was referenced Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants