Fixed issue #1742 where the creation of GPM object tried to connect t…

[aguvillalba]

…o Remote repositories even if only Local package was needed

Now, it only tries to connect to the outside world when really required and not when just creating a new GPM object.
This could break client classes with the following code:

$gpm = new GPM();
$gpm->grav->getVersion(); //or any other grav method

The above code must be replaced with:

$gpm = new GPM();
$gpm->loadRemoteGrav();
$gpm->grav->getVersion(); //or any other grav method

[mahagr]

Cannot see this being called from anywhere...?

[aguvillalba]

It's used in the admin plugin, in the classes/gpm.php to allow to load the Remote Grav repository.

[mahagr]

The issue I'm seeing here is that it is a new function which wasn't there before. So it's not compatible backwards, which needs to be noted.

[rhukster]

I need to test this. Also it will require the dependency of the admin on this Grav update as without it you will get an error.

These kinds of changes are a bit scary because if you manually update admin before core, the GPM will be broken because the method will not exist, and you won't be able to update core past that point. I would prefer a more backwards compatible approach to prevent this scenario.

[aguvillalba]

@rhukster I have already made the modifications and PR in the admin plugin to use this new function, so if the PR in the admin plugin is accepted, it will not cause any issue. As you suggested in the admin plugin, checking if the method exists before using it is a good solution for now.
IMHO, the problem that I see here is that the design of the application is not using real dependency injection (only service locator), so the design is not flexible and it is not straight forward to solve things like this elegantly without breaking things. For instance, the GPM class exposes to the outside the Grav instance as a public property, which breaks the encapsulation.
Anyway, as you suggested in the admin plugin, checking for the method before using it allows backwards compatibility.