Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name key Composer 2.0 compatible #48

Merged
merged 1 commit into from
May 18, 2020

Conversation

N-Parsons
Copy link
Contributor

  • Uppercase characters in name cause a deprecation warning (or error in 2.0).
  • This commit coerces the developer name to lowercase within name.
  • Plugin name is already coerced to lowercase elsewhere.

- Uppercase characters in `name` cause a deprecation warning (or error in 2.0).
- This commit coerces the developer name to lowercase within `name`.
- Plugin name is already coerced to lowercase elsewhere.
@mahagr mahagr self-requested a review May 18, 2020 07:09
@rhukster rhukster merged commit 922169f into getgrav:develop May 18, 2020
@rhukster
Copy link
Member

Cheers for this, had so many problems with first versions of composer 2.0 that I rolled back to 1.10.

@N-Parsons N-Parsons deleted the enforce-composer-lowercase branch May 18, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants