Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inherited theme is after new theme #9

Closed
JohnMica opened this issue Dec 4, 2016 · 4 comments
Closed

inherited theme is after new theme #9

JohnMica opened this issue Dec 4, 2016 · 4 comments
Labels
bug

Comments

@JohnMica
Copy link

JohnMica commented Dec 4, 2016

when using the cmd line to create a new theme with inheritance, the new theme appears before the inherited theme in the new-theme.yaml thus rendering all modifications / css/twig/etc... useless ..
@rhukster
Copy link
Member

rhukster commented Dec 4, 2016

well that's not good! :) should just be a matter of adjusting the template..

@rhukster rhukster added the bug label Dec 4, 2016
rhukster added a commit that referenced this issue Oct 2, 2017
@rhukster
Fixed inheritance order #9
40a5a86
@rhukster
Copy link
Member

rhukster commented Oct 2, 2017

Ack missed this for last release, will release again.

@rhukster rhukster closed this as completed Oct 2, 2017
@hughbris
Copy link
Contributor

hughbris commented Jan 8, 2018 •
edited
Loading

Reminder to push this into next release please @rhukster, just got bit by it and lost some time and cranial follicle before realising it was a bug! :) At least I don't have to create an issue/PR, thanks @JohnMica

@hughbris hughbris mentioned this issue Feb 8, 2018
Merged
@hughbris
Copy link
Contributor

hughbris commented Mar 2, 2018 •
edited
Loading

Bump! https://discourse.getgrav.org/t/theme-inheritance-not-working-properly/5822

edit: not the same problem it seems but this still needs to be integrated into release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hughbris @rhukster @JohnMica