Add taxonomy values date format customization #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to customize taxonomy value dates form (and thus, indirectly, URLs), akin to taxonomy names customization. Non-breaking change: defaults to previous behavior.
|
I needed URLs to look like If this MR is accepted, I am willing to update |
|
@rhukster Can you take a look? |
|
looks good to me, nicely backward compatible as it falls back to the existing hardcoded values if not set. |
nbusseneau
added a commit
to nbusseneau/grav-theme-quark
that referenced
this pull request
Oct 26, 2020
Take advantage of taxonomy_values format coming from the plugin settings. See getgrav/grav-plugin-archives#29 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to customize taxonomy value dates form (and thus, indirectly, URLs), akin to taxonomy names customization.
Non-breaking change: defaults to previous behavior.