Add possibility to filter from a specific page. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, my use case: I have blog items and portfolio items (and some other stuff), and I wanted to display archives only on (and for) blog items. If I used "@self" in blog.md, the archives would be correctly gathered on blog items list, but not on an blog item itself (which has no children). So I used "@page: /blog" in my archives.yml, and changed the archives.php file to find all children of whatever "@page" could be. Is this the correct way?
|
Hi, is there a reason not to merge this pull request? I have the same use case and would love to see this functionality added to the plugin :) |
|
I'm just working my way through plugins at the moment and not gotten to reviewing archives plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
my use case: I have blog items and portfolio items (and some other stuff), and I wanted to display archives only on (and for) blog items. If I used "@self" in blog.md, the archives would be correctly gathered on blog items list, but not on an blog item itself (which has no children).
So I used "@page: /blog" in my archives.yml, and changed the archives.php file to find all children of whatever "@page" could be.
Is this the correct way?