Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete responsive images added in the Page Media area #111

Closed
jpfleury opened this issue Aug 27, 2015 · 6 comments
Closed

Can't delete responsive images added in the Page Media area #111

jpfleury opened this issue Aug 27, 2015 · 6 comments
Assignees

Comments

@jpfleury
Copy link

Steps:

  • Add an image named [email protected] by uploading it in the Page Media area.
  • When the image is uploaded, save the page.
  • Put the cursor over the image in the Page Media area and click Delete.
  • Click Continue.

Result: we have this error:

An error occurred while trying to remove the file image.jpg

File not found: image.jpg
@rhukster
Copy link
Member

This kinda goes along with the other responsive image issue #109

@flaviocopes
Copy link
Contributor

@rhukster when uploading [email protected], the image is stored as [email protected] in the page folder. Before saving, in the Admin Page Media it's listed as [email protected]. After saving it's listed as image.jpg.

I think that's correct.
When deleting that image, should it try to delete all the possible versions, in short:

?

@rhukster
Copy link
Member

The retina-ness should be transparent when using the images in your content.. So if you have uploaded an [email protected] image, you actually only use and reference the image.jpg in your tags. This is because Grav is handling writing out the string with all the various versions appropriate for your browser.

However it might be nice to have a little flag or badge on the image in the media tray, so you know it's a @3x image.

And you are correct, if you delete the image, it should delete all versions of it that grav has created.

@flaviocopes
Copy link
Contributor

So it should also list it as image.jpg right after the upload (before saving), instead of [email protected]

@flaviocopes
Copy link
Contributor

That should also fix #109

@rhukster
Copy link
Member

yes, it should list as image.jpg, but have a badge saying @3x. I think this is the best way to represent it, and should work properly when adding to the markdown via drag-n-drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants