Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: url of upgrade button of pro #2520

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

osmansufy
Copy link
Contributor

@osmansufy osmansufy commented Jan 20, 2025

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

  • Closes #

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

  • Improvements
    • Updated upgrade button URL in admin header with enhanced tracking parameters
    • Improved link tracking for potential pro version conversions

@osmansufy osmansufy requested a review from mrabbani January 20, 2025 04:02

This comment was marked as off-topic.

@osmansufy
Copy link
Contributor Author

@jamil-mahmud Bhai ,
Upgrade to pro button link URL change.

@osmansufy osmansufy self-assigned this Jan 20, 2025
@osmansufy osmansufy added urgent Needs: Dev Review It requires a developer review and approval labels Jan 20, 2025
@mrabbani mrabbani added PM Dependency 👍 Dev Review Done Needs: Dev Review It requires a developer review and approval and removed Needs: Dev Review It requires a developer review and approval 👍 Dev Review Done labels Jan 21, 2025
@mrabbani mrabbani added 👍 Dev Review Done Upcoming Release and removed Needs: Dev Review It requires a developer review and approval labels Jan 22, 2025
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team QA In Progress and removed QA In Progress labels Jan 24, 2025
@shohag121 shohag121 merged commit fbae1b1 into develop Jan 28, 2025
6 checks passed
@shohag121 shohag121 deleted the upgrade-to-pro-link-url branch January 28, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants