Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add CustomersController: Vendor-specific CRUD, Batch, and Search API for Customer Management #2406

Conversation

mralaminahamed
Copy link
Member

@mralaminahamed mralaminahamed commented Oct 21, 2024

All Submissions:

  • My code follows the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

This PR introduces a new CustomersController class that implements REST API endpoints for vendor-specific customer management. This new controller allows vendors to perform various operations on their customer base through the REST API, providing a comprehensive set of endpoints for customer-related actions.

Key changes include:

  • Add new CustomersController class extending WC_REST_Customers_Controller
  • Implement the following REST API endpoints:
    1. GET /dokan/v1/customers - List customers
    2. POST /dokan/v1/customers - Create a new customer
    3. GET /dokan/v1/customers/{id} - Retrieve a specific customer
    4. PUT /dokan/v1/customers/{id} - Update a specific customer
    5. DELETE /dokan/v1/customers/{id} - Delete a specific customer
    6. POST /dokan/v1/customers/batch - Batch update customers
    7. GET /dokan/v1/customers/search - Search for customers (new vendor-specific functionality)
  • Implement permission checks to ensure only authorized vendors can access these endpoints
  • Include detailed PHPDoc for the new filter dokan_json_search_found_customers

Related Pull Request(s)

  • N/A

Closes

  • Closes #[Issue number]

How to test the changes in this Pull Request:

  1. Set up a vendor account with some orders from customers
  2. Test each endpoint:
    • GET /wp-json/dokan/v1/customers - Should list customers for the vendor
    • POST /wp-json/dokan/v1/customers - Should create a new customer
    • GET /wp-json/dokan/v1/customers/{id} - Should retrieve a specific customer
    • PUT /wp-json/dokan/v1/customers/{id} - Should update a specific customer
    • DELETE /wp-json/dokan/v1/customers/{id} - Should delete a specific customer
    • POST /wp-json/dokan/v1/customers/batch - Should perform batch operations on customers
    • GET /wp-json/dokan/v1/customers/search?search=John - Should search for customers
  3. Verify that only customers associated with the current vendor are accessible
  4. Ensure that non-vendor users cannot access these endpoints
  5. Test the search functionality with various parameters (e.g., exclude, limit)

Changelog entry

Feat: Add CustomersController: Vendor-specific CRUD, Batch, and Search API for Customer Management

This PR introduces a new CustomersController class that implements a set of REST API endpoints allowing vendors to manage and search for their customers. This new controller provides CRUD operations for customers, as well as a vendor-specific search functionality, offering a standardized and accessible interface for developers and external applications to interact with vendor-specific customer data.

Before Changes

Previously, vendor-specific customer management and search functionality were limited and not easily accessible through a standardized API. Vendors had to rely on AJAX actions or custom implementations to manage their customer data.

After Changes

With this change, a new CustomersController class is introduced, providing a comprehensive set of REST API endpoints for vendor-specific customer management. These endpoints allow vendors to list, create, retrieve, update, and delete customers, as well as perform batch operations and conduct searches. The new controller ensures proper permission checks and adheres to WordPress and WooCommerce coding standards.

Feature Video (optional)

N/A

PR Self Review Checklist:

  • Code follows style guidelines
  • Naming is clear and descriptive
  • Code is simple and straightforward (KISS principle)
  • No code duplication (DRY principle)
  • Code is readable and well-structured
  • Performance considerations have been taken into account
  • Complex constructions are refactored or commented
  • No grammar errors in comments and documentation

FOR PR REVIEWER ONLY:

  • Correct — Does the change do what it's supposed to?
  • Secure — Are there any security concerns?
  • Readable — Is the code easy to understand?
  • Elegant — Does the change fit well with the overall style and architecture?

Summary by CodeRabbit

  • New Features

    • Introduced a new REST API controller for managing customer data, enabling a search functionality for customers.
    • Added a new endpoint for searching customers, allowing for exclusion of specific customer IDs.
  • Improvements

    • Enhanced vendor permission checks for customer data retrieval and actions.

This commit introduces a new REST API endpoint for searching customers
specific to a vendor's orders. Key changes include:

- Add new route `/dokan/v1/customers/search` in CustomersController
- Implement `search_customers` method with the following features:
  * Search customers by ID or term (name/email)
  * Limit results to customers who have ordered from the current vendor
  * Support excluding specific customer IDs
  * Limit results to 20 when search term is less than 3 characters
  * Apply `dokan_json_search_found_customers` filter for extensibility
- Add permission check to ensure only users with 'edit_shop_orders' capability can access
- Include detailed PHPDoc for the new filter

This feature allows vendors to efficiently search their customer base
through the REST API, mirroring the functionality of the existing AJAX action
while providing a standardized API interface.
@mralaminahamed mralaminahamed self-assigned this Oct 21, 2024
@mralaminahamed mralaminahamed added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Oct 21, 2024
Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a new CustomersController class within the Dokan plugin framework, enhancing the REST API for managing customer data. This controller extends the existing WC_REST_Customers_Controller and adds functionalities such as a new search endpoint. The Manager class is updated to register this new controller in the REST API class map, enabling it to handle requests related to customer management, including permission checks and data preparation.

Changes

File Change Summary
includes/REST/CustomersController.php - Added CustomersController class.
- Implemented methods for registering routes, searching customers, and permission checks.
- Updated methods to enforce vendor permissions and prepare customer data for the database.
includes/REST/Manager.php - Added mapping for CustomersController in the $class_map array within the get_rest_api_class_map method.

Poem

In the land of code where rabbits play,
A new controller hops in, brightening the day.
Searching for customers, oh what a delight,
With permissions in check, everything's right!
So let’s celebrate this change, oh so grand,
For in the world of plugins, we take a stand! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mralaminahamed mralaminahamed changed the title Feat: Add REST API endpoint for vendor-specific customer search Add CustomersController: Vendor-specific CRUD, Batch, and Search API for Customer Management Oct 21, 2024
@mralaminahamed mralaminahamed changed the base branch from develop to update/vendor-dashboard-structure October 21, 2024 07:57
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Outside diff range and nitpick comments (1)
includes/REST/Manager.php (1)

237-237: LGTM! Consider adding a comment for clarity.

The addition of the CustomersController to the class map is correct and aligns with the PR objectives. This will enable the new REST API endpoint for vendor-specific customer search.

For consistency with other recent additions, consider adding a comment above this line to briefly describe the purpose of this controller:

+                // Controller for handling customer-related REST API endpoints
                 DOKAN_DIR . '/includes/REST/CustomersController.php'              => '\WeDevs\Dokan\REST\CustomersController',
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ead0858 and 0077f78.

📒 Files selected for processing (2)
  • includes/REST/CustomersController.php (1 hunks)
  • includes/REST/Manager.php (1 hunks)
🧰 Additional context used
🪛 GitHub Check: Run PHPCS inspection
includes/REST/CustomersController.php

[failure] 28-28:
Opening parenthesis of a multi-line function call must be the last content on the line


[failure] 45-45:
Closing parenthesis of a multi-line function call must be on a line by itself

@mralaminahamed mralaminahamed changed the title Add CustomersController: Vendor-specific CRUD, Batch, and Search API for Customer Management Feat: Add CustomersController: Vendor-specific CRUD, Batch, and Search API for Customer Management Oct 21, 2024
Copy link
Member

@mrabbani mrabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add Test case for Customer

@mralaminahamed
Copy link
Member Author

@mrabbani I've implemented comprehensive test cases for the CustomerController API as requested.

@mralaminahamed mralaminahamed added the In Progress The issues is being worked on label Oct 23, 2024
@mralaminahamed mralaminahamed removed the In Progress The issues is being worked on label Oct 23, 2024
@Aunshon Aunshon merged commit 8b2b753 into getdokan:update/vendor-dashboard-structure Oct 25, 2024
1 check passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 25, 2024
12 tasks
@mralaminahamed mralaminahamed deleted the feat/customer-api branch October 28, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Dev Review It requires a developer review and approval Needs: Testing This requires further testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants