Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] Add AdhocToReprNapi #85

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[js] Add AdhocToReprNapi #85

merged 1 commit into from
Feb 16, 2022

Conversation

danielhenrymantilla
Copy link
Collaborator

This adds a AdhocToReprNapi(|js_env| Ok({ … })) convenience constructor, much alike iter::from_fn for iterators, to easily write ad-hoc ReprNapi implementors, especially useful for JsPromises that need to perform some js-specific post-cleanup logic.

@danielhenrymantilla danielhenrymantilla added the K-feature Kind: proposed new code to implement new behaviour label Feb 16, 2022
@danielhenrymantilla danielhenrymantilla self-assigned this Feb 16, 2022
@danielhenrymantilla danielhenrymantilla merged commit 4c2e261 into ditto-node-js Feb 16, 2022
@danielhenrymantilla danielhenrymantilla deleted the add_adhoc_to_reprnapi branch February 16, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielhenrymantilla danielhenrymantilla

Labels
K-feature Kind: proposed new code to implement new behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielhenrymantilla