Feature: stable header generation #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhenrymantilla
added
the
K-feature
This makes the generated header feature fixed-order iteration over the `#[ffi_export]`-ed functions (sorted by name), to palliate the lack of order-of-iteration guarantees from the internal `inventory` crate. This allows the so-generated header files to be tracked into, say, `git` and whatnot.
danielhenrymantilla
force-pushed
the
feature/fixed-order-header-generation
branch
from
6f6b8a2 to
5f46194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the generated header feature fixed-order iteration over the
#[ffi_export]-ed functions (sorted by name), to palliate the lack of order-of-iteration guarantees from the internalinventorycrate. For the rare case where people liked the previous heuristic better, there is a way to opt out of this new heurstic, through the.stable_header(false)adaptor on the builder.This allows the so-generated header files to be tracked into, say,
gitand whatnot.