Fix cli tests in windows

[ahtrotta]

Fixes getappmap/board#188

[dividedmind]

Looks good, thanks! I had some questions, and some stylistic suggestions but you're free to take them or leave them.

The only thing I'm particularly (not too much though) concerned about is the prettier change. I'd rather we don't see crlf in the repository one day ;)

If the tests are fixed, can we change travis configuration to run the full CLI test suite on Windows now?

[ahtrotta]

Thanks for the excellent review! I addressed all of your comments. Let me know if you have any other questions or concerns.

I made it so all of the tests except for one run in Windows on Travis.

[dividedmind]

Why does this test need to be filtered? If there's something left to fix for this issue, that's fine, but please remember to create another one to keep track of the loose end.

[ahtrotta]

This one gives this error in Travis on Windows:

You can see it in the logs on this build: https://app.travis-ci.com/github/getappmap/appmap-js/jobs/585469980#L220

I'll make a new issue for it.

[dividedmind]

Thanks for the excellent review! I addressed all of your comments. Let me know if you have any other questions or concerns.

I made it so all of the tests except for one run in Windows on Travis.

Thanks, that looks much better! Now I'm only worried about those line endings. Perhaps it would be a good idea to add a gitattributes per-file eol override for the affected expectation files to prevent git from breaking the tests. (It'd probably look like

packages/cli/tests/unit/fixtures/encodedFile/**/* eol=lf
packages/cli/tests/unit/fixtures/encodedFile/windows/* eol=crlf

— haven't checked if it actually works, YMMV. Another option would be to do -text for all these files so git leaves them alone.)

[ahtrotta]

I put all of the tests into the platform-specific describe blocks in encodedFile.spec.ts, and all of the tests except for one are passing.

The strange thing is that this test passes for me locally on Windows and on Linux, so I'm not sure how to debug this. I tried changing the .travis.yml file, but it didn't do anything.

Do you have any thoughts?

[ahtrotta]

Okay, I got it to work. Turns out that forcing CRLF in the Windows files using:

/packages/cli/tests/unit/fixtures/encodedFile/windows/**/* eol=crlf

was causing issues on Travis. I'm not sure why. But I needed to force LF for the Unix test files for it to work on Windows.

Let me know if there's anything else you think needs to be changed!

[dividedmind]

Looks great now, thanks for figuring out this pesky EOL business!

(Please remember to rebase and fixup everything before merging.)

[appland-release]

🎉 This PR is included in version @appland/appmap-v3.45.0 🎉

The release is available on:

• @appland/appmap-v3.45.0
• GitHub release
• NPM publish

Your semantic-release bot 📦🚀