fix: use static path in function path

When there is only one version of a file available, we should use the
static path format. This was already the case in the classmap but not
in the event section. I added validation in tests to prevent
regressions.

components/trace/appmap/codebase/index.mjs

@@ -120,40 +120,42 @@ export const lookupClosureLocation = (
   const { url, hash, position } = location;
   if (codebase.has(url)) {
     const { shallow, versions } = codebase.get(url);
-    if (hash === null) {
-      if (/* c8 ignore start */ versions.size === 0) {
-        throw new InternalAppmapError("unexpected source without version");
-      } /* c8 ignore stop */ else if (versions.size === 1) {
-        const {
-          value: { source },
-        } = versions.values().next();
-        return completeClosure(
-          source,
-          toStaticSpecifier(url, base),
-          shallow,
-          position,
-        );
-      } else {
-        logWarning(
-          "Ignoring closure at %j because its source has multiple versions",
-          location,
-        );
-        return null;
-      }
-    } else if (versions.has(hash)) {
-      const { source, version } = versions.get(hash);
+    if (/* c8 ignore start */ versions.size === 0) {
+      throw new InternalAppmapError("unexpected source without version");
+    } /* c8 ignore stop */ else if (versions.size === 1) {
+      const {
+        value: { source },
+      } = versions.values().next();
       return completeClosure(
         source,
-        toDynamicSpecifier(url, base, version),
+        toStaticSpecifier(url, base),
         shallow,
         position,
       );
     } else {
-      logWarning(
-        "Ignoring closure at %j because of source content mismatch",
-        location,
-      );
-      return null;
+      if (hash === null) {
+        logWarning(
+          "Ignoring closure at %j because its source has multiple versions",
+          location,
+        );
+        return null;
+      } else {
+        if (versions.has(hash)) {
+          const { source, version } = versions.get(hash);
+          return completeClosure(
+            source,
+            toDynamicSpecifier(url, base, version),
+            shallow,
+            position,
+          );
+        } else {
+          logWarning(
+            "Ignoring closure at %j because of source content mismatch",
+            location,
+          );
+          return null;
+        }
+      }
     }
   } else {
     logWarningWhen(

test/cases/apply-async/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/apply-generator/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/apply-mismatch/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/apply-pattern/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/apply-rest/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/apply-source/appmap.yml

@@ -18,3 +18,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/classmap/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/default-parameter/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/env-var/appmap.yml

@@ -16,3 +16,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/eval/appmap.yml

@@ -15,3 +15,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/generator-method/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/html/appmap.yml

@@ -18,3 +18,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/http/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/jest-json/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/jest-transformer-preset/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/jest-transformer/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/jest/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/metadata/appmap.yml

@@ -16,3 +16,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/mocha/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/npx/appmap.yml

@@ -21,3 +21,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/query/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: true
+validate:
+  appmap: true

test/cases/to-string/appmap.yml

@@ -14,3 +14,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/ts-node-esm/appmap.yml

@@ -21,3 +21,5 @@ hooks:
   mysql: false
   pg: false
   sqlite3: false
+validate:
+  appmap: true

test/cases/version/appmap.yml

@@ -1 +1,2 @@
-{}
+validate:
+  appmap: true