fix: Please consider using fetch instead of XMLHttpRequest #29

[fishcakeday]

Replace cross-fetch with @inrupt/universal-fetch to fix #29 and enable usage in Worker edge environment.

[bumi]

Thanks for the PR and raising this!
@inrupt/universal-fetch does not seem to be much widespread?
I am actually tempted to just drop cross-fetch and leave it up to the user of the library to make sure there is a global fetch available - which is slowly universal, just older node versions have the issue and are still used.

[fishcakeday]

This will work too, I am uncertain if this package needs support for ancient browsers[1] that do not have fetch() implemented. And node usage can be covered by node-fetch[2]. What do you think?

[1] https://caniuse.com/fetch
[2] https://www.npmjs.com/package/node-fetch

[bumi]

Browser are fine, but I care about node and the dev experience there.

but I guess we can throw an error if global.fetch is not defined and tell the user to install a global fetch option?

something that we do for WebSockets in the alby-js-sdk: https://github.com/getAlby/alby-js-sdk/blob/master/src/webln/NostrWeblnProvider.ts#L75-L78

do you think this is good?

[fishcakeday]

That definitely solves the issue. I am uncertain if it is good, but if you are already doing similar thing in the other package, then it wouldn't hurt.

[rolznz]

Closing as fixed by #32

@fishcakeday Thanks for reporting this issue and creating the original PR!