Remove InvMEGAN manual diagnostics from hcox_megan_mod.F90

[yantosca]

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This is the companion PR to issue #281 by @eamarais. We have now removed the calls to Diagn_Create that set up manual InvMEGAN diagnostics. These can be scheduled by adding the appropriate entries to HEMCO_Diagn.rc.

Expected changes

This is a zero-diff update. However, we expect to gain a performance benefit by not having to update the manual diagnostics on each HEMCO timestep.

Related Github Issue

• Closes Comment out manual InvMEGAN diagnostic creation code #281

[yantosca]

Integration tests are now in progress.

[yantosca]

Integration tests are in progress.

[yantosca]

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #8730985 GEOS-Chem submod update: Merge PR #2372 (Disable MEGAN in non-bmk sims)
GEOS-Chem #03287a67a Merge PR #2372 (Turn off MEGAN extension for non-benchmark sims)
HEMCO     #ebd4177 Remove InvMEGAN manual diagnostics from hcox_megan_mod.F90

Using 24 OpenMP threads
Number of execution tests: 28

Submitted as SLURM job: 39699970
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All tests were zero-diff w/r/t PR #2372, except:

• TOMAS (parallelization error?)
• APM (parallelization error?)

Also, differences were noted in the HEMCO diagnostics output for the following simulations:

• fullchem_benchmark
• tagCO

This is because the following variables are no longer included in the diagnostic output:

float InvMEGAN_AAXX(time, lat, lon) ;
float InvMEGAN_FAXX(time, lat, lon) ;
float InvMEGAN_MBOX(time, lat, lon) ;
float InvMEGAN_OSQT(time, lat, lon) ;
float InvMEGAN_BCAR(time, lat, lon) ;
float InvMEGAN_FARN(time, lat, lon) ;
float InvMEGAN_OMON(time, lat, lon) ;
float InvMEGAN_OCIM(time, lat, lon) ;
float InvMEGAN_CARE(time, lat, lon) ;
float InvMEGAN_MYRC(time, lat, lon) ;
float InvMEGAN_SABI(time, lat, lon) ;
float InvMEGAN_BPIN(time, lat, lon) ;
float InvMEGAN_APIN(time, lat, lon) ;
float InvMEGAN_ACET_DIRECT(time, lat, lon) ;
float InvMEGAN_ACET_MBOX(time, lat, lon) ;

[yantosca]

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #094f53b GEOS-Chem submod update: Merge PR #2372 (Disable MEGAN in non-bmk sims)
GEOS-Chem #03287a67a Merge PR #2372 (Turn off MEGAN extension for non-benchmark sims)
HEMCO     #

Number of execution tests: 11

Submitted as SLURM job: 39700133
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all tests were identical to PR #2372. Differences were noted in the Emissions collection file, but this is because the following diagnostics are no longer included:

float InvMEGAN_AAXX(time, lat, lon) ;
float InvMEGAN_FAXX(time, lat, lon) ;
float InvMEGAN_MBOX(time, lat, lon) ;
float InvMEGAN_OSQT(time, lat, lon) ;
float InvMEGAN_BCAR(time, lat, lon) ;
float InvMEGAN_FARN(time, lat, lon) ;
float InvMEGAN_OMON(time, lat, lon) ;
float InvMEGAN_OCIM(time, lat, lon) ;
float InvMEGAN_CARE(time, lat, lon) ;
float InvMEGAN_MYRC(time, lat, lon) ;
float InvMEGAN_SABI(time, lat, lon) ;
float InvMEGAN_BPIN(time, lat, lon) ;
float InvMEGAN_APIN(time, lat, lon) ;
float InvMEGAN_ACET_DIRECT(time, lat, lon) ;
float InvMEGAN_ACET_MBOX(time, lat, lon) ;

[msulprizio]

This is a straightforward pull request, simply removing the manual diagnostics code from the MEGAN extension. Looks good to merge.