Implementing serde (De)Serialize for GPX structs #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to users.This PR resolves #59, by implementing optional support for (de-)serializing the GPX structs via serde.
I named the feature flag
serde-serialize
, same as in thewasm-bindgen
crate.Using
serde
for the feature flag name is not yet possible, since it would require the currently unstable cargo namespaced features implementation.See also the related cargo tracking issue.
It was asked in #59, whether it would be possible to use GeoJSON, but for my usecase, it would be overkill to deal with additional data structure conversions.
I also checked the Rust API guidelines, which mention that it would be good, if structs implemented
serde::{Serialize, Deserialize}
.If the changes are okay and can/should be merged, I'll update the branch with a changelog entry.