-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Coordinate into Point type #16
Conversation
This simplifies the Point API and removes an unnecessary abstraction level. Resolves georust#15
as suggested in georust#3
da2ff25
to
af7ca3c
Compare
@georust/core Considering this is a breaking change, might be good to get some feedback here I'm personally fine with this change |
So after a couple days of thinking, here are my thoughts:
I'm slightly in favor of going to down the latter route. What do you think @Turbo87 ? |
@frewsxcv It was designed around geojson which is by far the most pragmatic geospatial format |
JTS and libgeos has separated |
@frewsxcv I have not thought about MultiPolygons yet and never actually used them, but I also don't see how that is related to Points and Coordinates. @calvinmetcalf as mentioned in #15 already: modeling after GeoJSON can work, but since JSON doesn't have a proper type system we can actually do much better in Rust. GeoJSON needs both Point and Coordinate because of the @sunng87 the advantage is a simpler API and I honestly don't see any risks or disadvantages at this point. If I'm missing something then please tell me. |
I mentioned this, because if we decide to go this route and not make MultiPolygon not consist of Polygons, this pull request should probably not merged |
closing due to inactivity |
Move tests to their appropriate submodule
This simplifies the Point API and removes an unnecessary abstraction level.
Resolves #15