Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs to clarify writing Intersection Matrix functions #1135

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

urschrei
Copy link
Member

@urschrei urschrei commented Jan 3, 2024

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Following on from discussion in https://github.com/georust/geo/pull/1133/files/c1a57d18ccc4d03a00d71fb1c0bd079be1cdb806..f8aab2d44143c2cd96023876c0399b94465680a5 this PR adds documentation and examples with the aim of making writing and/or modifying spatial predicate functions easier for our future selves / new contributors.

This PR should be rebased once #1133 merges

@urschrei urschrei requested a review from michaelkirk January 3, 2024 17:30
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the underlying PR is passing, these docs look good.

I had one take it or leave it suggestion.

geo/src/algorithm/relate/geomgraph/intersection_matrix.rs Outdated Show resolved Hide resolved
@urschrei urschrei enabled auto-merge January 10, 2024 21:28
@urschrei urschrei added this pull request to the merge queue Jan 10, 2024
Merged via the queue into georust:main with commit 182b632 Jan 10, 2024
15 checks passed
@urschrei urschrei deleted the document_relate branch January 10, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants