-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an explicit include to gdal-src Cargo.toml #579
Conversation
Ouch, that's still a lot of MB, thanks! EDIT: nvm. |
I can merge this, but it will be up to @jdroenner to publish the initial version. |
I can push a commit for that as well if you want. |
Sure, let's add those. |
I can do the empty release later today. Anything i need to be aware of? |
This commit adds an explicit include to the `Cargo.toml` file of gdal-src to minimize the amount of code uploaded to crates.io. This reduces the uncompressed package size from >100MB to ~50MB. This is still larger than what's allowed by crates.io by default, but I know that it is possible to get an exception from these default limits by just asking with a good reason. Source code from an existing established open source project counts as good reason, so that's just something that needs to be done before publishing the first version.
0509f49
to
d7904a2
Compare
No, not really. It's just that the database entry must exist, so that they can just add an exception manually. |
what should we fill in for homepage and documentation? A link to georust/gdal on github? |
Same as the other crates, I guess? |
i created the empty crate: https://crates.io/crates/gdal-src |
Turns out this was much too optimistic 😔. |
@jdroenner @weiznich did any of you write to the crates.io team? Should I send an email? |
I did not write them yet. In my experience the fastest way to reach them is via Zulip: https://rust-lang.zulipchat.com/#narrow/channel/318791-t-crates-io I can write them a message there if that desired. |
I've just sent an email, that's the preferred option. |
Looks like we got the limit bumped to 50 MB compressed, which is hopefully enough (I think we're at 12 MB, even after #580). |
This commit adds an explicit include to the
Cargo.toml
file of gdal-src to minimize the amount of code uploaded to crates.io. This reduces the uncompressed package size from >100MB to ~50MB. This is still larger than what's allowed by crates.io by default, but I know that it is possible to get an exception from these default limits by just asking with a good reason. Source code from an existing established open source project counts as good reason, so that's just something that needs to be done before publishing the first version.The last time I had this problem the workflow was as follows:
CHANGES.md
if knowledge of this change could be valuable to users.