ENH: capture all errors logged by gdal when opening a file fails #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for working on this @theroggy ! A few suggestions re: naming things.
I added links to them in the PR description... |
theroggy
commented
Nov 12, 2024
…d all logic was moved to clean_error_message
…duplicate code in ErrorHandler
…ors-logged-by-gdal-when-opening-a-file-fails
|
This appears to be raising a lot of test errors on GDAL 3.4.3 specifically; is that expected? |
No... I've had a look at it... but I didn't really see why these errors occur... and even less why these changes triggered them to start failing. If you have an idea... very welcome. |
…ors-logged-by-gdal-when-opening-a-file-fails
Support for OGR_GEOJSON_MAX_OBJ_SIZE with float values only for gdal >= 3.5.2 by PR https://github.com/OSGeo/gdal/pull/6177/files#diff-821a801ab3a6e3e8ad5fa9883c48daf282b2ea5d4150408c57a62adff626652b
|
@brendan-ward I found and fixed the issue with gdal < 3.5.2... |
brendan-ward
reviewed
Dec 5, 2024
…ors-logged-by-gdal-when-opening-a-file-fails
theroggy
deleted the
ENH-capture-all-errors-logged-by-gdal-when-opening-a-file-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was present in Rasterio (rasterio/rasterio#2526) and has been included in fiona::_err recently (Toblerity/Fiona#1408)... so this PR is based on the change there.
Closes #491