-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter / Remove unused Groovy mode. #7346
Conversation
ed011c3
to
eb71797
Compare
Groovy formatter is unused and unmaintained in GeoNetwork. It is also unused in the (only one?) project which used it (geocat.ch) since 2 years now. This PR propose to remove it.
eb71797
to
83eddb1
Compare
@fxprunayre probably this file requires to be updated also: core-geonetwork/services/src/main/java/org/fao/geonet/api/records/formatters/Resource.java Lines 129 to 131 in 3609c5d
Should not be removed the full test related to https://github.com/geonetwork/core-geonetwork/pull/7346/files#diff-2b14577e24e139d9bb75bd503ec5dbb1f4f78f926107b2fc022d9e228317a5a0R63 ? |
Done. About the test, we can keep but indeed I think XSLT formatter never added extra resources like images/css/js in the formatter bundle. We can maybe cleanup this later if really unused. |
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Groovy formatter is unused and unmaintained in GeoNetwork. It is also unused in the (only one?) project which used it (geocat.ch) since ~2 years now.
This PR propose to remove it.
List of groovy formatters:
See
https://github.com/geonetwork/core-geonetwork/tree/main/schemas/iso19139/src/main/plugin/iso19139/formatter
https://github.com/geonetwork/core-geonetwork/tree/main/web/src/main/webapp/WEB-INF/data/data/formatter