Java11 compatibility and Spring 5 updates #7186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a first try to address the following: #4668 Tested so far: Compilation OK using both jdk 11 & 8 available for debian sid Tests: failure with jdk11, OK with jdk8 Runtime: Ok with a very basic usage on JRE11. Webapp was able to bootstrap, loading default schemas + samples MD, browsing the admin UI interface ... Skimming the wiki page: https://github.com/geonetwork/core-geonetwork/wiki/Java-11-Compatibility it seems that the leg work will be to actually clean up the classloader from the different dependencies being in several versions in the classpath, but as a first shot, it sounds mainly OK.
testing both versions, one with extra "/" or without.
Does not work yet, I'd like to find some german dates which could be parsed using the java.time API.
* keeping the jdk8 test when runtime is compatible * deactivating the other one when jdk11 tests: ok on both jdk8 and 11.
…or integration tests to use Java 11
juanluisrp
requested changes
Jul 14, 2023
harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/geoPREST/Harvester.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/fao/geonet/api/OpenApiController.java
Outdated
Show resolved
Hide resolved
harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/geoPREST/Harvester.java
Outdated
Show resolved
Hide resolved
harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/geoPREST/Harvester.java
Outdated
Show resolved
Hide resolved
harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/geoPREST/Harvester.java
Outdated
Show resolved
Hide resolved
harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/geoPREST/Harvester.java
Outdated
Show resolved
Hide resolved
…er/geoPREST/Harvester.java Co-authored-by: Juan Luis Rodríguez Ponce <[email protected]>
…er/geoPREST/Harvester.java Co-authored-by: Juan Luis Rodríguez Ponce <[email protected]>
…er/geoPREST/Harvester.java Co-authored-by: Juan Luis Rodríguez Ponce <[email protected]>
…er/geoPREST/Harvester.java Co-authored-by: Juan Luis Rodríguez Ponce <[email protected]>
Co-authored-by: Juan Luis Rodríguez Ponce <[email protected]>
…M change to version 11
|
SonarCloud Quality Gate failed.
|
juanluisrp
approved these changes
Jul 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #6276 with library updates (Spring, Hibernate).
Address some security vulnerabilities reported by Trivy tool.
To be discussed: