Support phoenix_html 3.0 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfilej Thanks so much for the PR and sorry for the delays in getting this reviewed. Were you able to test on staging?
I have another person doing a bit of testing, but I think this will be good to go early next week. |
|
@geolessel No worries. Unfortunately we haven't had the chance to use this internally as the project has been put on hold. |
|
❤️ Closes #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version requirement for phoenix_html to include 3.0.
The tests are passing and things seem ok after a quick sanity check. Will do further testing once this reaches our staging servers.
I'm not sure you want all these updates to mix.lock - let me know if you want to reduce them down to just phoenix_html (or not even that)?