feature(react_component): allow html_element and other options
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndrewMurph @lustrousgorilla Are these changes still ok for you two? Nothing really changed since I last asked in #42 but I thought I'd re-check in with you. Sorry this took so long! |
Looks fantastic @geolessel ! Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the user to more precisely configure the rendered HTML output from
react_component/3.html_elementBy default,
react_componentrenders the react component inside adivcontainer. If you pass a value tohtml_elementas an option toreact_component/3, it will render the component inside the specified HTML element. For example, to render the component in aspaninstead of adiv, you can runOther options
Anything else passed into
react_component/3will be passed through directly to the component's HTML output. This could be a class name, styles, or anything else.This takes care of the request in #42.