Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split GitHub Action for linting into YAML Lint and Ansible Lint #3

Closed
geoffreyvanwyk opened this issue Dec 29, 2023 · 0 comments · Fixed by #26
Closed

Split GitHub Action for linting into YAML Lint and Ansible Lint #3

geoffreyvanwyk opened this issue Dec 29, 2023 · 0 comments · Fixed by #26
Assignees
@geoffreyvanwyk
Labels
enhancement New feature or request role Regards the created role
Milestone
Good Enough v3.1.0

Comments

@geoffreyvanwyk
Copy link
Owner

geoffreyvanwyk commented Dec 29, 2023 •
edited
Loading

See how it is done in the Learning Sandbox Online project.

Rather than installing yamllint and ansible-lint directly, rather install from the requirements.txt file to make sure that the same version is used in GitHub Actions than in development.
@geoffreyvanwyk geoffreyvanwyk added the enhancement New feature or request label Dec 29, 2023
@geoffreyvanwyk geoffreyvanwyk self-assigned this Dec 29, 2023
@geoffreyvanwyk geoffreyvanwyk added the role Regards the created role label Dec 30, 2023
@geoffreyvanwyk geoffreyvanwyk added this to the Good Enough v4.0.0 milestone Dec 30, 2023
geoffreyvanwyk added a commit that referenced this issue Jan 8, 2024
@geoffreyvanwyk
feat(role): add Ansible linting to build workflow
8b3a81b 
* Make each job dependent on the previous one.
* Use specific Ubuntu version, the same as in development.
* Install Python packages from requirements.txt, so that the build
   environment matches development.
* Remove unnecessary (?) working-directory variable.

Issues: #3
geoffreyvanwyk added a commit that referenced this issue Jan 8, 2024
@geoffreyvanwyk
feat(role): add Ansible linting to build workflow
044193e 
* Make each job dependent on the previous one.
* Use specific Ubuntu version, the same as in development.
* Install Python packages from requirements.txt, so that the build
   environment matches development.
* Remove unnecessary (?) working-directory variable.
* Disable YAML lint rule for "on" keyword of GitHub Actions.

Issues: #3
@geoffreyvanwyk geoffreyvanwyk mentioned this issue Jan 8, 2024
Merged
geoffreyvanwyk added a commit that referenced this issue Jan 8, 2024
@geoffreyvanwyk
feat(role): add Ansible linting to build workflow
e35372e 
* Make each job dependent on the previous one.
* Use specific Ubuntu version, the same as in development.
* Install Python packages from requirements.txt, so that the build
   environment matches development.
* Remove unnecessary (?) working-directory variable.
* Disable YAML lint rule for "on" keyword of GitHub Actions.

Issues: #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffreyvanwyk geoffreyvanwyk

Labels
enhancement New feature or request role Regards the created role
Projects
None yet
Milestone
Good Enough v3.1.0
Development

Successfully merging a pull request may close this issue.

feat(role): add Ansible linting to build workflow geoffreyvanwyk/cookiecutter-ansible-role
1 participant
@geoffreyvanwyk