Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/pybedtools: version bump 0.11.0 and enable docs #1316

Closed
wants to merge 1 commit into from

Conversation

mschubert
Copy link
Contributor

No description provided.

@@ -24,11 +24,9 @@ RDEPEND="
dev-python/pandas[${PYTHON_USEDEP}]
dev-python/matplotlib[${PYTHON_USEDEP}]
"
BDEPEND="dev-python/cython[${PYTHON_USEDEP}]"
Copy link
Member

@Nowa-Ammerlaan Nowa-Ammerlaan Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency on cython is not required when DISTUTILS_EXT=1 is set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this and am now getting a QA Notice:

  • QA Notice: Package seems to be missing a BDEPEND on dev-python/cython.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please check if you are using the most recent version of the eclass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the main tree synced at 2025-01-27 11:18:44 UTC, so this should include the latest distutils-r1 eclass. I still get the QA notice

Copy link
Member

@Nowa-Ammerlaan Nowa-Ammerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x55c30ed92fbf internal_error(char const*, ...)
???:0
0x55c30d335cf8 read_cgraph_and_symbols(unsigned int, char const**)
???:0
0x55c30d2f9807 lto_main()
???:0
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status
compilation terminated.

It fails to build on my end

@mschubert
Copy link
Contributor Author

Was this with USE=doc?

I realized I misunderstood how I still have to set this flag for sphinx, so that is likely broken (looking into it)

@Nowa-Ammerlaan
Copy link
Member

Was this with USE=doc?

I realized I misunderstood how I still have to set this flag for sphinx, so that is likely broken (looking into it)

It was, but not sure if the error originates from sphinx.

@mschubert
Copy link
Contributor Author

I've disabled the docs again, making this a simple version bump.

I don't know where the compile error comes from, does the current ebuild compile fine? And/or does reinstalling sci-biology/bedtools solve the problem? In this case, I'd think I'd have to add sci-biology/bedtools:0= to RDEPEND

@Nowa-Ammerlaan
Copy link
Member

Nowa-Ammerlaan commented Jan 30, 2025

It's still failing, looks like an lto issue, please try to build it with lto enabled on your end.

@mschubert
Copy link
Contributor Author

I can confirm this is broken with -flto, but this already happens with the previous version 0.10.0.

I've got no idea how to debug this.

@Nowa-Ammerlaan
Copy link
Member

I can confirm this is broken with -flto, but this already happens with the previous version 0.10.0.

I've got no idea how to debug this.

Don't bother, just add filter-lto to the ebuild to ensure the lto flags are removed if they are present.

@mschubert
Copy link
Contributor Author

Added in the current commit

@Nowa-Ammerlaan
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants