Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose num #576

Merged
merged 7 commits into from
Mar 14, 2023
Merged

Expose num #576

merged 7 commits into from
Mar 14, 2023

Conversation

neworderofjamie
Copy link
Contributor

Implementing EventProp, I got annoyed enough to implement #553. As well as improving usability, with large models where multiple synapse/neuron groups are actually getting merged together, this will improve performance as otherwise the "special function" unit on GPUs can get saturated by float->int conversions

Fixes #553

@neworderofjamie neworderofjamie added this to the GeNN 4.8.1 milestone Mar 14, 2023
Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good - not too many surprises here either.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 97.95% and project coverage change: +0.06 🎉

Comparison is base (c578132) 88.85% compared to head (0c9c110) 88.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   88.85%   88.92%   +0.06%     
==========================================
  Files          76       76              
  Lines       12374    12393      +19     
==========================================
+ Hits        10995    11020      +25     
+ Misses       1379     1373       -6     
Impacted Files Coverage Δ
src/genn/genn/code_generator/initGroupMerged.cc 93.75% <95.65%> (+0.07%) ⬆️
...enn/genn/code_generator/customUpdateGroupMerged.cc 90.29% <100.00%> (+0.39%) ⬆️
src/genn/genn/code_generator/groupMerged.cc 86.94% <100.00%> (ø)
...enn/genn/code_generator/neuronUpdateGroupMerged.cc 93.18% <100.00%> (+0.03%) ⬆️
...nn/genn/code_generator/synapseUpdateGroupMerged.cc 96.00% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@neworderofjamie neworderofjamie merged commit 6b09eaa into master Mar 14, 2023
@neworderofjamie neworderofjamie deleted the expose_num branch March 14, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$(num_pre), $(num_post), $(num_batches) etc should be exposed everywhere
2 participants