Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max connections issues #515

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Conversation

neworderofjamie
Copy link
Contributor

This fixes two issues:

  1. Even if you've used a sparse connectivity initialisation snippet to initialise connectivity, as long as you're increasing it, you should still be able to manually increase max connections e.g. to leave a bit more padding at the end of each row for rewiring
  2. Max connections wasn't being included in hashes used to determine if model had changed so if you had build a model based on some manually specified connectivity and changed it you ended up in a really broken state

@neworderofjamie neworderofjamie added this to the GeNN 4.7.1 milestone Apr 28, 2022
Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable ...

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #515 (17204e4) into master (f3c1a0f) will increase coverage by 2.68%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   86.81%   89.50%   +2.68%     
==========================================
  Files          84       73      -11     
  Lines       18063    10565    -7498     
==========================================
- Hits        15682     9456    -6226     
+ Misses       2381     1109    -1272     
Impacted Files Coverage Δ
src/genn/genn/synapseGroup.cc 82.96% <16.66%> (-2.50%) ⬇️
src/genn/genn/code_generator/groupMerged.cc 86.05% <100.00%> (-2.72%) ⬇️
include/genn/genn/synapseGroupInternal.h 0.00% <0.00%> (-75.00%) ⬇️
src/genn/genn/code_generator/modelSpecMerged.cc 74.44% <0.00%> (-21.07%) ⬇️
include/genn/genn/snippet.h 74.35% <0.00%> (-10.72%) ⬇️
src/genn/genn/binomial.cc 63.79% <0.00%> (-5.89%) ⬇️
include/genn/genn/code_generator/codeStream.h 92.00% <0.00%> (-4.30%) ⬇️
src/genn/genn/code_generator/codeStream.cc 88.00% <0.00%> (-4.00%) ⬇️
include/genn/genn/code_generator/groupMerged.h 80.55% <0.00%> (-3.74%) ⬇️
src/genn/genn/currentSource.cc 78.43% <0.00%> (-3.39%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c1a0f...17204e4. Read the comment docs.

@neworderofjamie neworderofjamie merged commit a53cbca into master Apr 28, 2022
@neworderofjamie neworderofjamie deleted the override_max_connections branch April 28, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants