Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check event code for den delay #494

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

neworderofjamie
Copy link
Contributor

Until Anindya tried, clearly no one has tried using heterogeneous delays and spike-like events - the event code was never getting searched for addToInSynDelay so code wasn't compiling. Also added a unit test

@neworderofjamie neworderofjamie added this to the GeNN 4.7.0 milestone Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #494 (f3f87bc) into master (037af10) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files          84       84           
  Lines       17972    17976    +4     
=======================================
+ Hits        15625    15629    +4     
  Misses       2347     2347           
Impacted Files Coverage Δ
src/genn/genn/synapseGroup.cc 85.45% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037af10...f3f87bc. Read the comment docs.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh boy ... you do need users to find all the nasties ... looks like a straightforward fix, thanks.

@neworderofjamie neworderofjamie merged commit 4d11fab into master Jan 10, 2022
@neworderofjamie neworderofjamie deleted the check_event_code_for_den_delay branch January 10, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants