Fix multiple issues with sparse synapse index narrowing #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #274 I implemented support for 'narrow' sparse synapse indices so, if the postsynaptic population was < 65536 neurons,
uint16_t
would be used and if < 256 neurons,uint8_t
. However:uint32_t
- it now callsSynapseGroup::getSparseIndType
to get correct typepushXXConnectivityToDevice
andpullXXConnectivityToDevice
,unsigned int
was always being used - this also now uses the correct type.