Use symbolic links in /tmp to fix "path name spaces problem" #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and create havoc in Makefiles. Solves issue #424.
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 87.87% 87.98% +0.10%
==========================================
Files 78 78
Lines 16575 16575
==========================================
+ Hits 14566 14583 +17
+ Misses 2009 1992 -17
Continue to review full report at Codecov.
|
bin/genn-buildmodel.sh
Outdated
| # Use pushd to get an absolute path and symbolic links in /tmp to avoid problems | ||
| # with spaces in the path names | ||
| pushd "$OUT_PATH" > /dev/null | ||
| OUT_PATH=/tmp/genn_outpath$RANDOM |
There was a problem hiding this comment.
It would be marginally nicer to use OUTPUT=$(mktemp) (and MODEL=$(mktemp)) instead. Better chance of being robust to multiple users running GeNN simultaneously on the same machine.
/tmp is specified specifically as a location as the default location on Mac looks quite horrible which I feel could lead to confusion when displayed in the make command lines. -u is necessary as we want to create a symlink, not a regular file.
neworderofjamie
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424.