-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced __linux macro in path library #363
Conversation
… POWER9 GCC. Replaced with ``__linux__``
@alexdewar - probably a little unlikely someone tries to use BoB Robotics on POWER9, but I can believe this might also not being properly set on something embedded |
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 86.67% 86.66% -0.01%
==========================================
Files 64 64
Lines 10138 10138
==========================================
- Hits 8787 8786 -1
- Misses 1351 1352 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff ;-) - obviously needs to be done.
From those of us using ppc64le, thank you! |
@qhaas Please tell me you are running GeNN on your POWER9? 😆 |
'My' Power9, heavens no... it is the taxpayer's power9. My wife would never approve of me dropping the $$$ for my very own IBM AC922 or Raptor Talos 2, as cool as that would be ;) But, the researcher in Issue #362 is running GeNN on that Power9 powered HPC, I was merely helping troubleshoot the compilation issue. |
Ah, that does look rather big to keep at home 😉. It's pretty cool to know that you've got GeNN running on that beast though! |
https://sourceforge.net/p/predef/wiki/OperatingSystems/ suggests it's deprecated but it has never been an issue apart from on a POWER9 machine. Nonethless, replacing it with the more standard
__linux__
solves the problem.