Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced __linux macro in path library #363

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Replaced __linux macro in path library #363

merged 1 commit into from
Sep 28, 2020

Conversation

neworderofjamie
Copy link
Contributor

https://sourceforge.net/p/predef/wiki/OperatingSystems/ suggests it's deprecated but it has never been an issue apart from on a POWER9 machine. Nonethless, replacing it with the more standard __linux__ solves the problem.

@neworderofjamie neworderofjamie added this to the GeNN 4.4.0 milestone Sep 28, 2020
@neworderofjamie neworderofjamie linked an issue Sep 28, 2020 that may be closed by this pull request
@neworderofjamie neworderofjamie changed the title Replaced __linux macro Replaced __linux macro Sep 28, 2020
@neworderofjamie neworderofjamie changed the title Replaced __linux macro Replaced __linux macro in path library Sep 28, 2020
@neworderofjamie
Copy link
Contributor Author

neworderofjamie commented Sep 28, 2020

@alexdewar - probably a little unlikely someone tries to use BoB Robotics on POWER9, but I can believe this might also not being properly set on something embedded

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #363 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   86.67%   86.66%   -0.01%     
==========================================
  Files          64       64              
  Lines       10138    10138              
==========================================
- Hits         8787     8786       -1     
- Misses       1351     1352       +1     
Impacted Files Coverage Δ
src/genn/backends/cuda/optimiser.cc 75.87% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf10ee1...83c44e8. Read the comment docs.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting stuff ;-) - obviously needs to be done.

@neworderofjamie neworderofjamie merged commit 8d5f38b into master Sep 28, 2020
@neworderofjamie neworderofjamie deleted the power branch September 28, 2020 17:22
@qhaas
Copy link

qhaas commented Sep 28, 2020

From those of us using ppc64le, thank you!

@alexdewar
Copy link
Collaborator

@qhaas Please tell me you are running GeNN on your POWER9? 😆

@qhaas
Copy link

qhaas commented Sep 29, 2020

your POWER9

'My' Power9, heavens no... it is the taxpayer's power9. My wife would never approve of me dropping the $$$ for my very own IBM AC922 or Raptor Talos 2, as cool as that would be ;)

But, the researcher in Issue #362 is running GeNN on that Power9 powered HPC, I was merely helping troubleshoot the compilation issue.

@alexdewar
Copy link
Collaborator

Ah, that does look rather big to keep at home 😉. It's pretty cool to know that you've got GeNN running on that beast though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeNN while using along with Brian2genn fails on Power9
4 participants